quiesce needs to keep track of blueprint ids #8919
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some sample output from the new Initial state: Enabled blueprint execution: Created a demo saga: Start quiescing: Complete the demo saga: |
jgallagher
reviewed
Aug 28, 2025
nexus/types/src/quiesce.rs
Outdated
| /// whether a saga recovery operation is ongoing, and if one is: | ||
| /// - what `reassignment_generation` was when it started | ||
| /// - which blueprint id we'll be fully caught up to upon completion | ||
| #[serde(skip)] // XXX-dap |
There was a problem hiding this comment.
XXX here because we don't want to skip this field?
There was a problem hiding this comment.
Yes -- sorry I missed that! This is a problem because we don't support a tuple in this context in the OpenAPI spec. I will replace it with a struct.
nexus/types/src/quiesce.rs
Outdated
| } | ||
| }; | ||
|
|
||
| q.latch_drained_blueprint_id(); |
There was a problem hiding this comment.
Is it correct to latch this even if quiescing is false?
There was a problem hiding this comment.
Yes, the function checks that.
edit: to be precise, it is not correct to latch the value in this case. The function latch_drained_blueprint_id is intended to be called at any time and will only latch the state if appropriate, and it checks that. Is there a better name for that?
There was a problem hiding this comment.
latch_blueprint_id_if_drained() maybe?
jgallagher
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of #8859. This PR adds the logic to keep track of this. Once we have db_metadata_nexus records (currently #8845), the last bit of 8859 will be to update those records whenever this value changes.
This is still a work in progress. I need to add some new tests and also put this into
omdb.